From 5145bb8982eb5dbe81d6f7e68a61bda42c14b2d5 Mon Sep 17 00:00:00 2001 From: Anton Vasiliev Date: Tue, 2 May 2023 20:51:27 +0100 Subject: [PATCH 1/2] #141 - Change `RuntimeException` throw to output warning message --- src/Migrations.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Migrations.php b/src/Migrations.php index 1df4279..782203c 100644 --- a/src/Migrations.php +++ b/src/Migrations.php @@ -270,7 +270,8 @@ public static function run(array $options) join(PHP_EOL, $migrationsDirList) : $migrationsDirList; - throw new RuntimeException('Migrations were not found at:' . PHP_EOL . PHP_EOL . $migrationsPath); + echo Color::error('Migrations were not found at:' . $migrationsPath, 'Warning: '); + return; } // Set default final version From 6058786e1f2f8d73909e1e885dd0677006453b61 Mon Sep 17 00:00:00 2001 From: Anton Vasiliev Date: Tue, 2 May 2023 22:55:26 +0100 Subject: [PATCH 2/2] #141 - Comment unworked line --- src/Db/FieldDefinition.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Db/FieldDefinition.php b/src/Db/FieldDefinition.php index 91459a1..0fe6c20 100644 --- a/src/Db/FieldDefinition.php +++ b/src/Db/FieldDefinition.php @@ -132,7 +132,7 @@ public function isChangedName(FieldDefinition $comparingFieldDefinition): bool public function isChangedData(FieldDefinition $comparingFieldDefinition): bool { $paramsToCheck = get_class_methods(ColumnInterface::class); - unset($paramsToCheck['getName']); + //unset($paramsToCheck['getName']); // TODO: Validate if this even needed. $comparingFieldColumn = $comparingFieldDefinition->getColumn(); foreach ($paramsToCheck as $method) {