Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Phalcon\Events #17

Closed
niden opened this issue Sep 6, 2020 · 0 comments · Fixed by #51
Closed

Refactor Phalcon\Events #17

niden opened this issue Sep 6, 2020 · 0 comments · Fixed by #51
Assignees
@niden
Labels
6.0.0 6.0.0 release new feature request Planned Feature or New Feature Request
Projects
Phalcon native

Comments

@niden
Copy link
Sponsor Member

niden commented Sep 6, 2020

Refactor Phalcon\Events
@niden niden added new feature request Planned Feature or New Feature Request 6.0.0 6.0.0 release labels Sep 7, 2020
@niden niden added this to Backlog in Phalcon native Oct 5, 2020
niden added a commit to niden/phalcon that referenced this issue Oct 8, 2020
@niden
feat(events): added events - translating them from zephir
fdf40a1 
Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 8, 2020
@niden
feat(events): fixtures/listeners for events
e1aa2a1 
Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 8, 2020
@niden
test(events): added events/event tests
f4b0642 
Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 8, 2020
@niden
style(tests): hopefully this is the last time I deal with docblocks
138dd61 
Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 8, 2020
@niden
feat(events): repositioning of the declare statement below the docblo…
bc0303d 
…ck (psr-12)

Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 8, 2020
@niden
feat(events): minor correction to the declare statement psr-12
1a8cd8d 
Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 10, 2020
@niden
feat(events): added events aware trait and tests
422c3ab 
Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 10, 2020
@niden
feat(events): added tests for events and additional fixtures
d8959dd 
Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 10, 2020
@niden
feat(events): added events manager as well as tests fo rit
6289afa 
Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 10, 2020
@niden
style: code sniffer
49235fc 
Refs phalcon#17
@niden niden mentioned this issue Oct 10, 2020
Merged
5 tasks
@niden niden linked a pull request Oct 10, 2020 that will close this issue
T17 events #51
Merged
5 tasks
niden added a commit to niden/phalcon that referenced this issue Oct 10, 2020
@niden
refactor: adjustments and refactoring: removed else statements, chang…
9fc12ee 
…ed variable names for clarity

Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 10, 2020
@niden
feat(events): cleared up mistake from previous run
756a0df 
Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 10, 2020
@niden
style: dockblock
a53ace8 
Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 11, 2020
@niden
refactor: codacy driven corrections; removed else statements, early e…
a7ea189 
…xits, introduced helper traits

Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 11, 2020
@niden
style: phpcs
5eb9fb5 
Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 11, 2020
@niden
refactor(events): reworked the fire method to avoid else statements
a0bb1ee 
Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 11, 2020
@niden
refactor(events): removed unused variables
16f56bc 
Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 11, 2020
@niden
style(event): added docblock return types as per the CR
e9a01d8 
Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 11, 2020
@niden
test: adjustments to the testing suite (code coverage)
0cd74d3 
Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 11, 2020
@niden
test: removed obsolete tests; added more tests
04bab50 
Refs phalcon#17
niden added a commit to niden/phalcon that referenced this issue Oct 11, 2020
@niden
Trying a different format for scrutinizer
1d11103 
Refs phalcon#17
Phalcon native automation moved this from Backlog to Implemented Oct 12, 2020
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
feat(events): added events - translating them from zephir
059ac5f 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
feat(events): fixtures/listeners for events
ddfc3d3 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
test(events): added events/event tests
a5391f2 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
style(tests): hopefully this is the last time I deal with docblocks
fc36fdf 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
feat(events): repositioning of the declare statement below the docblo…
6364b34 
…ck (psr-12)

Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
feat(events): minor correction to the declare statement psr-12
0acfb10 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
feat(events): added events aware trait and tests
0e681b5 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
feat(events): added tests for events and additional fixtures
d11be3d 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
feat(events): added events manager as well as tests fo rit
a767723 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
style: code sniffer
6fd3798 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
refactor: adjustments and refactoring: removed else statements, chang…
c274421 
…ed variable names for clarity

Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
feat(events): cleared up mistake from previous run
276f1d3 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
style: dockblock
0e62004 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
refactor: codacy driven corrections; removed else statements, early e…
1740bb6 
…xits, introduced helper traits

Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
style: phpcs
7f478da 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
refactor(events): reworked the fire method to avoid else statements
42c9e7d 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
refactor(events): removed unused variables
daefc6f 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
style(event): added docblock return types as per the CR
a32e674 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
test: adjustments to the testing suite (code coverage)
0f941af 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
test: removed obsolete tests; added more tests
4709d0a 
Refs phalcon#17
thicolares pushed a commit to thicolares/phalcon that referenced this issue Oct 21, 2020
@niden @thicolares
Trying a different format for scrutinizer
1d5aebb 
Refs phalcon#17
@niden niden self-assigned this Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
6.0.0 6.0.0 release new feature request Planned Feature or New Feature Request
Projects
Phalcon v6
Status: Implemented
Phalcon native
Implemented
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

T17 events niden/phalcon
1 participant
@niden