Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zephir stubs - missing "use" statements #1778

Closed
niden opened this issue Dec 11, 2018 · 1 comment
Assignees
Labels
bug
Projects

Comments

@niden
Copy link
Member

@niden niden commented Dec 11, 2018

The stubs generated using zephir stubs are missing the use statements at the top of the file.

This might not be a problem since for most of the stubs we have the fully qualified namespace for certain elements i.e.

    /**
     * Sets the dependency injector
     *
     * @param \Phalcon\DiInterface $container
     */
    public function setDI(\Phalcon\DiInterface $container) {}

However it seems return variables are not properly parsed

    /**
     * Returns the internal dependency injector
     *
     * @return \Phalcon\DiInterface
     */
    public function getDI(): DiInterface {}

The same happens with variables

    /**
     * @var <UrlInterface>
     */
    private $url;

I think either we need to add the use statements at the top of the file or parse variables as well as return values with the full namespaces.

@sergeyklay sergeyklay added the bug label Dec 11, 2018
@danhunsaker danhunsaker added this to Needs triage in Zephir Bugs Dec 12, 2018
@sergeyklay sergeyklay moved this from Needs triage to Low priority in Zephir Bugs Jan 31, 2019
@AlexNDRmac AlexNDRmac referenced this issue Oct 10, 2019
2 of 3 tasks complete
@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Oct 10, 2019

Fixed in development branch. Thank you for the bug report!

@sergeyklay sergeyklay closed this Oct 10, 2019
Zephir Bugs automation moved this from Low priority to Closed Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Zephir Bugs
  
Closed
3 participants
You can’t perform that action at this time.