Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about test suite #1949

Closed
remicollet opened this issue Oct 4, 2019 · 9 comments
Labels
bug

Comments

@remicollet
Copy link
Contributor

@remicollet remicollet commented Oct 4, 2019

There were 2 errors:

1) Extension\InternalClassesTest::testStaticMethodCall
Error: Class 'Phalcon\Di' not found

/dev/shm/BUILD/zephir-1c107e0c8966233f0d35156419e2c97729dcc4ce/unit-tests/Extension/InternalClassesTest.php:24

2) Extension\InternalClassesTest::testStaticPropertyFetch
Error: Class 'Phalcon\Mvc\Model\Query' not found

/dev/shm/BUILD/zephir-1c107e0c8966233f0d35156419e2c97729dcc4ce/unit-tests/Extension/InternalClassesTest.php:30

ERRORS!
Tests: 539, Assertions: 1646, Errors: 2.

Where do these classes come from ?
Of course, when phalcon ext is installed, test suite passes, but fails without

@sergeyklay sergeyklay added the bug label Oct 4, 2019
@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Oct 4, 2019

I hope I fixed this in 650708d. Thank you for the bug report.

@remicollet

This comment has been minimized.

Copy link
Contributor Author

@remicollet remicollet commented Oct 4, 2019

Yes, thanks

Build + test suite tested with PHP 7.2, 7.3 and 7.4

@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Oct 4, 2019

@remicollet Question: do you provide rpm for Zephir ?

@remicollet

This comment has been minimized.

Copy link
Contributor Author

@remicollet remicollet commented Oct 4, 2019

Yes, but for now only version 0.10 used to build stable phalcon 3.4

phalcon 4 is available in "testing" repository, but build without zephir (which was broken, but need to do more tests and report any issue)

As soon, as I will be able to build phalcon 4 using zephir 0.12, it will be in the repo.

@remicollet

This comment has been minimized.

Copy link
Contributor Author

@remicollet remicollet commented Oct 4, 2019

FYI, using zephir 0.12.4 (or 0.12.7) and phalcon 4.0.0rc.1

+ /usr/bin/zephir clean
+ /usr/bin/zephir fullclean
+ /usr/bin/zephir generate

                                                                                                                        
 [ERROR] Method '__construct' was defined more than one time                                                            

Any idea ?
Should I open a phalcon or zephir bug report ?

@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Oct 4, 2019

@remicollet I think it is Phalcon bug

@remicollet

This comment has been minimized.

Copy link
Contributor Author

@remicollet remicollet commented Oct 4, 2019

I think it is Phalcon bug

ok, reported as https://github.com/phalcon/cphalcon/issues/14446

@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Oct 4, 2019

Can we close this one?

@remicollet remicollet closed this Oct 4, 2019
@sergeyklay

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.