Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: cannot generates sources to build Phalcon 4.0.0-rc.1 when timecop is enabled #1950

Closed
remicollet opened this issue Oct 4, 2019 · 6 comments
Labels
bug

Comments

@remicollet
Copy link
Contributor

@remicollet remicollet commented Oct 4, 2019

Using zephir 0.12.4 (or 0.12.7)

+ /usr/bin/zephir clean
+ /usr/bin/zephir fullclean
+ /usr/bin/zephir generate

                                                                                                                        
 [ERROR] Method '__construct' was defined more than one time                                                            
                                                                                                                        

@remicollet

This comment has been minimized.

Copy link
Contributor Author

@remicollet remicollet commented Oct 4, 2019

Hmm... can be related to installed extension in dev. env.

Using a minimal env, this works...

@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Oct 4, 2019

@remicollet What version do you have installed?

@remicollet

This comment has been minimized.

Copy link
Contributor Author

@remicollet remicollet commented Oct 4, 2019

What version do you have installed?

Version of what ? ;)

BTW, found the faulty extension: timecop.
When remove, "zephir generate" succeeds

Perhaps need to be documented ?

@remicollet remicollet changed the title [BUG]: cannot generates sources to build 4.0.0-rc.1 [BUG]: cannot generates sources to build 4.0.0-rc.1 when timecop is enabled Oct 4, 2019
@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Oct 4, 2019

@remicollet Is this related to #1588 ?

@remicollet

This comment has been minimized.

Copy link
Contributor Author

@remicollet remicollet commented Oct 4, 2019

Yes

@sergeyklay sergeyklay transferred this issue from phalcon/cphalcon Oct 4, 2019
@sergeyklay sergeyklay added the bug label Oct 4, 2019
@sergeyklay sergeyklay changed the title [BUG]: cannot generates sources to build 4.0.0-rc.1 when timecop is enabled [BUG]: cannot generates sources to build Phalcon 4.0.0-rc.1 when timecop is enabled Oct 4, 2019
@sergeyklay sergeyklay referenced this issue Oct 12, 2019
2 of 3 tasks complete
@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Oct 12, 2019

Zephir now prints a warning during the code generation if the timecop extension was detected. Introduced in the development branch. Feel free to open a new issue if the problem appears again. Thank you for bug report.

@sergeyklay sergeyklay closed this Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.