Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zephir stubs allow multiline @param #1968

Closed
Jurigag opened this issue Oct 13, 2019 · 1 comment
Assignees

Comments

@Jurigag
Copy link
Member

@Jurigag Jurigag commented Oct 13, 2019

When the parameter is provided like this:

     * @param array options = [
     *     'prefix' => 'phalcon'
     *     'lifetime' => 3600
     * ]

Which is totally correct phpdoc, it helps for plugin https://github.com/klesun/deep-assoc-completion to autocomplete code.

It's not detected correctly as parameter, it just add those lines as they are and additionally adds another @param from method parameters. I guess current regexp needs somehow to change https://github.com/phalcon/zephir/blob/development/Library/Stubs/MethodDocBlock.php#L110 here but im not regexp expert.

sergeyklay added a commit that referenced this issue Oct 17, 2019
…lock-params

Enchacement | #1968 multiline docblock params
@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Oct 17, 2019

Closing, this is implemented. If there are bugs, we can follow up in separate issues.

@sergeyklay sergeyklay closed this Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.