Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zephir stubs shouldn't add 'void' return type hint #1977

Closed
sergeyklay opened this issue Oct 17, 2019 · 0 comments · Fixed by #1978

Comments

@sergeyklay
Copy link
Member

@sergeyklay sergeyklay commented Oct 17, 2019

As a far as Zephir supports PHP 7.0 the stubs command should generate methods with void return type hint:

- public function foo(): void
+ public function foo()
  {
  }

Currently this work so only if PHP 7.0 is used by generating stubs.

JellyBrick added a commit to JellyBrick/zephir that referenced this issue Oct 17, 2019
@JellyBrick JellyBrick referenced this issue Oct 17, 2019
1 of 3 tasks complete
sergeyklay added a commit that referenced this issue Oct 17, 2019
Temporary fix #1977
dreamsxin added a commit to dreamsxin/zephir that referenced this issue Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.