Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local memory management #1880

Merged
merged 2 commits into from Jun 28, 2019

Conversation

@dreamsxin
Copy link
Member

commented Jun 28, 2019

Hello!

  • Type: new feature
  • Link to issue: #1859

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Thanks

@dreamsxin dreamsxin requested a review from sergeyklay Jun 28, 2019
Copy link
Member

left a comment

❤️

@dreamsxin dreamsxin changed the title [WIP]Use local memory management - DONT MERGE!! [WIP]Use local memory management Jun 28, 2019
@dreamsxin

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

@sergeyklay continuous-integration/appveyor/pr failed

@dreamsxin

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

Can help fix it and merge @sergeyklay

@sergeyklay

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

@dreamsxin

C:\projects\zephir\ext\kernel\memory.c(86): error C2373: 'zephir_memory_restore_stack': redefinition; different type modifiers
C:\projects\zephir\ext\kernel/memory.h(66): note: see declaration of 'zephir_memory_restore_stack'
operators.c
require.c
string.c
time.c
@dreamsxin dreamsxin merged commit 765f726 into phalcon:development Jun 28, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sergeyklay

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

Thank you!

@sergeyklay sergeyklay changed the title [WIP]Use local memory management Use local memory management Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.