New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stubs beautiful #418

Merged
merged 2 commits into from Jun 3, 2014

Conversation

Projects
None yet
2 participants
@ovr
Contributor

ovr commented May 27, 2014

No description provided.

@@ -34,6 +34,7 @@ public function __construct($source, $indent = 4)
if (strpos($line, '@') === 0) {
$this->lines[] = $line;
} else {
$line = preg_replace('~([\s\t]+)[*]([\s\t]+)~', '', $line);

This comment has been minimized.

@nkt

nkt May 27, 2014

Contributor

Can you add test on this.
I can not understand what for you adds this replacing:(

This comment has been minimized.

@ovr

ovr May 27, 2014

Contributor

You said "delete stubs it is not needed in repo" :)))

    /**
     * Bla bla my method
     */
     public function method() {}

and see output without patch

/**
  * * Bla bla my method
 */

ovr added a commit that referenced this pull request Jun 3, 2014

@ovr ovr merged commit 5755bf0 into phalcon:master Jun 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment