New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move auto generated files from Kernel component #469

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@ovr
Contributor

ovr commented Aug 3, 2014

Because i would like to split kernel from projects
and added it like a submodule
https://github.com/zephir-lang/kernel

Because github analytics parse project see kernel and mark zephir's projects as c language project

With this patch it works currect
https://github.com/lynx/lynx

ovr added some commits Aug 3, 2014

@ovr

This comment has been minimized.

Owner

ovr commented on 7b3d2f2 Aug 3, 2014

Without it, README.md in ext/kernel was removed

@nkt

This comment has been minimized.

Contributor

nkt commented Aug 3, 2014

👍 to split kernel from Zephir
👎 add it as submodule to every project.
If you are worry about Github language mark - let's change kernel-files extension to zep.h/zep.c

@ovr

This comment has been minimized.

Contributor

ovr commented Aug 3, 2014

@nkt
Kernel is Compononent of Zephir written on C (not autogenerated by zephir)
Maybe another developer will use this project to write extension for php with Zephir.
It isn't correct way to avoid detetion by changing files ext's for components.
Why you hate git submodules?

@nkt

This comment has been minimized.

Contributor

nkt commented Aug 3, 2014

@ovr I don't hate submodules. I don't like do something, that someone have to do instead of me. In this case I have to control kernel version instead of composer.
And actually kernel files is written for Zephir. In every Zephir project - it's generated files. It similar to STL in C++.

@ovr

This comment has been minimized.

Contributor

ovr commented Aug 3, 2014

First, You can install zephir without Composer
This commit doesn`t add submodules to zephir project or zephir's projects
It splits only, and move autogenerated files from kernel as you can see.

Composer is a tool for dependency management in PHP.

Composer is not best way to install system libs.

@ghost

This comment has been minimized.

Collaborator

ghost commented Aug 4, 2014

👎 Not sure why is this a priority now

@ovr

This comment has been minimized.

Contributor

ovr commented Aug 4, 2014

@phalcon
Without kernel submodule my project marked as c language!

@ghost

This comment has been minimized.

Collaborator

ghost commented Aug 4, 2014

OMG such tragedy!!

@ovr

This comment has been minimized.

Contributor

ovr commented Aug 4, 2014

@phalcon okey, not a problem

@ovr ovr closed this Aug 4, 2014

@ovr ovr reopened this Aug 6, 2014

@ovr

This comment has been minimized.

Contributor

ovr commented Aug 6, 2014

I'll w8 for merge this commit
Becase I need kernel component without autogenereated files

@ovr ovr changed the title from Create own project contact.c to Move auto generated files from Kernel component Aug 6, 2014

@ovr ovr closed this Aug 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment