New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global static cache #956

Merged
merged 8 commits into from May 16, 2015

Conversation

Projects
None yet
2 participants
@andresgutierrez
Member

andresgutierrez commented May 16, 2015

Previous static-variable based cache in Zephir had problems in PHP-FPM or when functions/methods were overriden and it also wasn't available on Windows. This new cache implements a slot-based cache where functions and methods candidates of being cached are stored in a global indexed cache which should be safer than the static-variable based cache.

  • Methods marked as final/private are candidates to use this cache
  • Functions that are always bundled with PHP also benefit from this

andresgutierrez added a commit that referenced this pull request May 16, 2015

@andresgutierrez andresgutierrez merged commit 232e712 into master May 16, 2015

@ovr

This comment has been minimized.

Contributor

ovr commented May 17, 2015

Before

self::f()          2.245
self::f() -> true  2.285

Now

self::f()          2.165
self::f() -> true  2.218

@sergeyklay sergeyklay deleted the global-static-cache branch Mar 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment