Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please keep test in git tag #1986

Closed
remicollet opened this issue Sep 22, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@remicollet
Copy link
Contributor

commented Sep 22, 2018

Since 6ba6f30 we cannot retrieve tests anymore...

This way looks like a terrible solution, as even a git clone don't have the tests.

Using c37a053 instead of 1.0.5 tag (7dd5f93) can be a workaorund....

Other projects use the .gitattributes, which is another way to do bad things.

Tests are part of the project... old discussion... PHP world is the only one to do such awful things... only because we don't any any good installer (cpan, npm, ...) even pear was doing the work properly.

/me terribly sad.

@remicollet remicollet changed the title Please jeep test in git tag Please keep test in git tag Sep 22, 2018

@TysonAndre

This comment has been minimized.

Copy link
Member

commented Sep 22, 2018

I'll try to switch to .gitattributes for 1.0.6, wasn't sure how it worked (so it's the client downloading zips/tarballs that have the files excluded?)

A large part of the issue relative to other projects is that many of these files would cause static analyzers (older versions of Phan, and anything that assumes typical or valid code) to crash, because they're regression tests for crashes in Phan.

TysonAndre added a commit to TysonAndre/phan that referenced this issue Sep 22, 2018

Add .gitattributes for publishing releases
And remove script that was previously used to delete those files
(prior to creating a git commit for the release)

Closes phan#1986
@TysonAndre

This comment has been minimized.

Copy link
Member

commented Sep 25, 2018

1.0.6 is out - The zip and tarball both look good, and exclude those files.

The 1.0.6 git tag onwards is now back to being unmodified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.