Handle references in ClosureReturnTypeOverridePlugin #3176
Conversation
There was a problem hiding this comment.
I'm not 100% sure of this change, and I'd like to add some tests, but I don't know what's the right place for them.
Generally, new tests go in tests/files/src/ (incrementing numbers) with the corresponding expected file in tests/files/expected, unless it's specific to a non-default setting, or a plugin in .phan/plugins, or a php version.
I'd want some before merging this, to avoid breaking this functionality when refactoring in the future
| @@ -0,0 +1 @@ | |||
| %s:14 PhanImpossibleTypeComparison Impossible attempt to check if $y of type null is identical to 2 of type 2 | |||
There was a problem hiding this comment.
Unexpected output in ./tests/files/src/0762_closure_reference.php
Failed asserting that './tests/files/src/0762_closure_reference.php:15 PhanImpossibleTypeComparison Impossible attempt to check if $y of type false is identical to 2 of type 2\n
./tests/files/src/0762_closure_reference.php:31 PhanUnusedVariable Unused definition of variable $arg\n
' matches PCRE pattern "/^$/".
The file name should be .php.expected, not just .expected
Also, the variable on line 31 is unused
There was a problem hiding this comment.
Oh, didn't notice the .php, thanks.
As for the variable, well, it was supposed to be unused, so I'll suppress the issue.
| } | ||
|
|
||
| $z = false; | ||
| call_user_func_array('f762clos3', [ &$z ]); |
There was a problem hiding this comment.
This would probably treat call_user_func_array('f762clos3', [$z]) the same way, but fixing that seemed out of scope. A new issue type might be needed for a no-op reference.
I'd have to look into whether call_user_func_array('f762clos3', ['any literal or constant']) would emit a false positive.
There are probably edge cases with call_user_func('f762clos3', $z) as well, since $z can't be passed as a reference .
php > function setx(&$x) { $x = 2; }
php > call_user_func('setx', $x);
Notice: Undefined variable: x in php shell code on line 1
Warning: Parameter 1 to setx() expected to be a reference, value given in php shell code on line 1
php > var_export($x);
Notice: Undefined variable: x in php shell code on line 1
NULL
Fixes #2943.
I'm not 100% sure of this change, and I'd like to add some tests, but I don't know what's the right place for them.