Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for both client_id and clientId #43

Conversation

billyyyyy3320
Copy link
Contributor

Currently, the example in README doesn't work fine.

It only accepts client_id , but the example is using clientId:

      googleSignInParams: {
        clientId: 'YOUR_APP_CLIENT_ID.apps.googleusercontent.com'
      }

I tested it and found that both client_id and clientId could be accepted by google api.

@phanan
Copy link
Owner

phanan commented Feb 17, 2020

LGTM

@phanan phanan merged commit a9d3ef5 into phanan:master Feb 17, 2020
@phanan
Copy link
Owner

phanan commented Feb 17, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants