New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy and Rename command should not add a "-01" if the image name already ends with a number #274

Closed
jecisc opened this Issue Oct 30, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@jecisc
Copy link
Member

jecisc commented Oct 30, 2018

I tried to copy an image named "Iceberg-01" and the default named I got was "Iceberg-01-01". I would have expected an "Iceberg-02".

We can check if the name ends with numeric characters and increment it in that case. (Or maybe a character $- followed by numeric characters?)

@eMBee

This comment has been minimized.

Copy link

eMBee commented Jan 17, 2019

rename should probably not change the name at all, since i would not call rename to increment the number but change the name for other reasons.

@demarey

This comment has been minimized.

Copy link
Contributor

demarey commented Jan 28, 2019

@eMBee +1

demarey added a commit to demarey/pharo-launcher that referenced this issue Jan 28, 2019

@demarey demarey closed this Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment