New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pharo Launcher does not go beyond Pharo 7 #1384 image #281

Closed
astares opened this Issue Nov 27, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@astares
Copy link
Member

astares commented Nov 27, 2018

Meanwhile Pharo is at image build #1415
http://lists.pharo.org/pipermail/pharo-dev_lists.pharo.org/2018-November/273628.html

but Launcher on Windows does not show images beyond Pharo 7 #1384

This was also reported by Stephan eggermont on Slack.

@demarey

This comment has been minimized.

Copy link
Contributor

demarey commented Nov 27, 2018

You can get the latest image from Official Distributions > Pharo 70.
In the Pharo 7.0 (development version) group, latest versions are not shown because the naming changed. PharoLauncher uses the following regexp to list available versions:
href="(Pharo-7.0.0-alpha.build.[^"]*.zip)"

matcher := 'href="(Pharo-7.0.0-alpha.build.[^"]*.zip)"' asRegex.
matcher matches: 'href="Pharo7.0.0-rc1.build.1410.sha.5063419.arch.64bit.zip"'. "false"
matcher matches: 'href="Pharo-7.0.0-alpha.build.1379.sha.54328a7.arch.64bit.zip"' "true"

I will update this regexp in the upcoming PL version

@demarey

This comment has been minimized.

Copy link
Contributor

demarey commented Nov 27, 2018

should use href="(Pharo-?7.0.0-(alpha|rc\d+).build.[^"]*.zip)"regex

@astares

This comment has been minimized.

Copy link
Member Author

astares commented Nov 27, 2018

OK, I changed to:

pharo70
	^ self 
		name: 'Pharo 7.0 (development version)' 
		url: 'http://files.pharo.org/image/70/' asZnUrl
		filterPattern: 'href="(Pharo-?7.0.0-(alpha|rc\d+).build.[^"]*.zip)"'

in class PhLHTTPListingTemplateGroup and run

PhLTemplateGroupRepository resetGroups

and confirm that I now see #1416 build

@astares

This comment has been minimized.

Copy link
Member Author

astares commented Nov 27, 2018

Name: PharoLauncher-Core-TorstenBergmann.209
Author: TorstenBergmann
Time: 27 November 2018, 3:09:47.547739 pm
UUID: 5b3c35bd-0738-0d00-93d5-6fca0dc846da
Ancestors: PharoLauncher-Core-ChristopheDemarey.208

Fix for #281 as discussed on Discord #development channel today

@demarey demarey closed this Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment