New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipfile from 85bebb7 has no source file #293

Closed
guillep opened this Issue Jan 22, 2019 · 7 comments

Comments

Projects
None yet
2 participants
@guillep
Copy link
Member

guillep commented Jan 22, 2019

It seems the image generated from 85bebb7 is a pharo7 image but it has no source code.

@guillep

This comment has been minimized.

Copy link
Member Author

guillep commented Jan 22, 2019

I've tried adding the Pharo sources from the corresponding commit but it does not work. It seems that the launcher is condending changes? That's not good...

@guillep

This comment has been minimized.

Copy link
Member Author

guillep commented Jan 22, 2019

This makes ffi calls fail...

@demarey

This comment has been minimized.

Copy link
Contributor

demarey commented Jan 23, 2019

PL does not condense changes. I will take a look at it.

@demarey

This comment has been minimized.

Copy link
Contributor

demarey commented Jan 23, 2019

OS X app includes 6.1 sources file. It should now be 70 sources file.

@guillep

This comment has been minimized.

Copy link
Member Author

guillep commented Jan 23, 2019

Yeah, maybe, but even. If I add 70 sources file nothing works.

@demarey

This comment has been minimized.

Copy link
Contributor

demarey commented Jan 28, 2019

I fixed pb wih sources files. The other problem is that someone disabled PhLStartupManager registration to the startup list ... I reactivated it

@demarey

This comment has been minimized.

Copy link
Contributor

demarey commented Jan 28, 2019

looks to be fixed

@demarey demarey closed this Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment