New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working directory should be inherited from CLI #559
Comments
See visit
process := PhLProcessWrapper new.
process workingDirectory: self imageFile parent pathString.
… (a quick test after changing that seems to work, PR incoming) |
With GUI, launch from image directory (rather than filesystem root). Fixes pharo-project#559
With GUI, launch from image directory (rather than filesystem root). Fixes pharo-project#559
@cdlm Hi Damien! It's been a while since you did this change, but could you look at it? CI is failing after integration, see: https://ci.inria.fr/pharo-ci-jenkins2/job/PharoLauncher-Pipeline/job/feature%252Fcmd-line/18/console
probably existing image launch configuration instances need to be re-initialized with correct working directory. What do you think? |
Waiting to CI to be up again. It should be fixed. by PR #604 |
Resolved by linked PRs. |
Context: launching an image via CLI, using the
pharo-launcher image launch IMAGENAME
commandWhat happens: the working directory is the image directory (
FileSystem disk workingDirectory = FileLocator imageDirectory asFileReference
is true).This is a problem because the user context is lost.
What should happen: the working directory (value of
$PWD
in the shell that invokes thepharo-launcher
wrapper script) should be inherited by the image.The text was updated successfully, but these errors were encountered: