Fix #8196 clean some shadowed variables

pharo-project · Dec 28, 2020 · 3bd86cf · 3bd86cf
1 parent 843f585
commit 3bd86cf
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/src/Clap-Core/ClapParameterized.class.st b/src/Clap-Core/ClapParameterized.class.st
@@ -27,8 +27,8 @@ ClapParameterized >> add: aParameter [
 ]
 
 { #category : #adding }
-ClapParameterized >> addAll: parameters [
-	parameters do: [ :each | each addTo: self ]
+ClapParameterized >> addAll: parametersToAdd [
+	parametersToAdd do: [ :each | each addTo: self ]
 ]
 
 { #category : #adding }

diff --git a/src/DrTests-Tests/DrTestsTestRunnerTest.class.st b/src/DrTests-Tests/DrTestsTestRunnerTest.class.st
@@ -71,8 +71,8 @@ DrTestsTestRunnerTest >> testRunResultIsDTTestRunnerResult [
 { #category : #tests }
 DrTestsTestRunnerTest >> testSelectedPackagesContainTestCases [
 
-	self assert: (plugin packagesAvailableForAnalysis allSatisfy: [ :package |
-		package definedClasses anySatisfy: [ :class |
+	self assert: (plugin packagesAvailableForAnalysis allSatisfy: [ :pkg |
+		pkg definedClasses anySatisfy: [ :class |
 			class isTestCase ] ])
 ]
 

diff --git a/src/Refactoring-Changes/RBCompositeRefactoryChange.class.st b/src/Refactoring-Changes/RBCompositeRefactoryChange.class.st
@@ -206,16 +206,16 @@ RBCompositeRefactoryChange >> renameChangesForClass: oldClassName to: newClassNa
 ]
 
 { #category : #'refactory-changes' }
-RBCompositeRefactoryChange >> renameClass: class to: newName [ 
-	^ self addChange: (changeFactory renameClass: class to: newName)
+RBCompositeRefactoryChange >> renameClass: class to: newNameLocal [ 
+	^ self addChange: (changeFactory renameClass: class to: newNameLocal)
 ]
 
 { #category : #'refactory-changes' }
-RBCompositeRefactoryChange >> renameClassVariable: oldName to: newName in: aClass [
-	^ self addChange: (changeFactory renameClassVariable: oldName to: newName in: aClass)
+RBCompositeRefactoryChange >> renameClassVariable: oldNameLocal to: newNameLocal in: aClass [
+	^ self addChange: (changeFactory renameClassVariable: oldNameLocal to: newNameLocal in: aClass)
 ]
 
 { #category : #'refactory-changes' }
-RBCompositeRefactoryChange >> renameInstanceVariable: oldName to: newName in: aClass [
-	^ self addChange: (changeFactory renameInstanceVariable: oldName to: newName in: aClass)
+RBCompositeRefactoryChange >> renameInstanceVariable: oldNameLocal to: newNameLocal in: aClass [
+	^ self addChange: (changeFactory renameInstanceVariable: oldNameLocal to: newNameLocal in: aClass)
 ]
diff --git a/src/Spec2-Core/SpDocumentHierarchyBuilder.class.st b/src/Spec2-Core/SpDocumentHierarchyBuilder.class.st
@@ -158,10 +158,10 @@ SpDocumentHierarchyBuilder >> fromClass: aClass [
 ]
 
 { #category : #testing }
-SpDocumentHierarchyBuilder >> isPassingThrough: aClass topLevel: topClass [
+SpDocumentHierarchyBuilder >> isPassingThrough: aClass topLevel: topClassLocal [
 	| superclasses |
 
-	superclasses := flattenTree at: topClass superclass ifAbsent: [ #() ].
+	superclasses := flattenTree at: topClassLocal superclass ifAbsent: [ #() ].
 	superclasses size <= 1 ifFalse: [ 
 		^ (superclasses indexOf: topClass) < superclasses size ].