From 7026dd150af801a22f290b4f673552e9fe355b88 Mon Sep 17 00:00:00 2001 From: Torsten Bergmann Date: Sun, 22 Nov 2020 16:33:39 +0100 Subject: [PATCH] Care on unused ivars in Renraku fix #7810 --- ...ReTempVarOverridesInstVarRuleTest.class.st | 20 +++++++++++++++++++ ...aseShouldNotUseInitializeRuleTest.class.st | 7 +++++++ src/Renraku/ReRemoveMethodCritique.class.st | 3 --- 3 files changed, 27 insertions(+), 3 deletions(-) diff --git a/src/GeneralRules-Tests/ReTempVarOverridesInstVarRuleTest.class.st b/src/GeneralRules-Tests/ReTempVarOverridesInstVarRuleTest.class.st index b2beb959f6d..12413dc3e1f 100644 --- a/src/GeneralRules-Tests/ReTempVarOverridesInstVarRuleTest.class.st +++ b/src/GeneralRules-Tests/ReTempVarOverridesInstVarRuleTest.class.st @@ -13,6 +13,26 @@ Class { #category : #'GeneralRules-Tests-Migrated' } +{ #category : #accessing } +ReTempVarOverridesInstVarRuleTest >> dummy1 [ + ^ dummy1 +] + +{ #category : #accessing } +ReTempVarOverridesInstVarRuleTest >> dummy2 [ + ^ dummy2 +] + +{ #category : #accessing } +ReTempVarOverridesInstVarRuleTest >> dummy3 [ + ^ dummy3 +] + +{ #category : #accessing } +ReTempVarOverridesInstVarRuleTest >> dummy4 [ + ^ dummy4 +] + { #category : #'test-help' } ReTempVarOverridesInstVarRuleTest >> sampleMethod: dummy1 [ "I override dummy1, dummy2, dummy3 " diff --git a/src/GeneralRules-Tests/ReTestCaseShouldNotUseInitializeRuleTest.class.st b/src/GeneralRules-Tests/ReTestCaseShouldNotUseInitializeRuleTest.class.st index 0959358b465..6ae74c0fff1 100644 --- a/src/GeneralRules-Tests/ReTestCaseShouldNotUseInitializeRuleTest.class.st +++ b/src/GeneralRules-Tests/ReTestCaseShouldNotUseInitializeRuleTest.class.st @@ -7,6 +7,13 @@ Class { #category : #'GeneralRules-Tests-Migrated' } +{ #category : #accessing } +ReTestCaseShouldNotUseInitializeRuleTest >> aDummyVar [ + "Only necessary that ivar does not appear unused" + + ^ aDummyVar +] + { #category : #running } ReTestCaseShouldNotUseInitializeRuleTest >> tearDown [ diff --git a/src/Renraku/ReRemoveMethodCritique.class.st b/src/Renraku/ReRemoveMethodCritique.class.st index 44b92168a03..85b2bcf3d2c 100644 --- a/src/Renraku/ReRemoveMethodCritique.class.st +++ b/src/Renraku/ReRemoveMethodCritique.class.st @@ -4,9 +4,6 @@ I am a critique that will propose to the user to remove a method. Class { #name : #ReRemoveMethodCritique, #superclass : #ReAbstractCritique, - #instVars : [ - 'selector' - ], #category : #'Renraku-Critiques' }