Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup newlines and blanks in "LibGit" packages #10542

Closed
astares opened this issue Nov 30, 2021 · 3 comments
Closed

Cleanup newlines and blanks in "LibGit" packages #10542

astares opened this issue Nov 30, 2021 · 3 comments

Comments

@astares
Copy link
Member

astares commented Nov 30, 2021

see #10396 and fix it for all "LibGit" related packages:

badCases := SystemNavigation default allMethodsSelect: [ :each | each sourceCode trimRight size ~= each sourceCode size ].

fixInPackage := badCases select: [:each | each package name beginsWith: 'LibGit' ].

fixInPackage do: [:each |
	| refactoring classOrTrait |
	classOrTrait := each traitSource ifNil: [ each methodClass ] ifNotNil: [ each traitSource innerClass ].
	refactoring := RBAddMethodChange compile: each sourceCode trimRight in: classOrTrait for: nil.				 
	refactoring execute	
]
@astares
Copy link
Member Author

astares commented Nov 30, 2021

We need to fix that in https://github.com/pharo-vcs/libgit2-pharo-bindings repository

GitHub
libgit2 bindings for Pharo. Contribute to pharo-vcs/libgit2-pharo-bindings development by creating an account on GitHub.

@astares
Copy link
Member Author

astares commented Nov 30, 2021

@tesonep, @estebanlm: If possible someone needs to double check and merge pharo-vcs/libgit2-pharo-bindings#58 to fix #10542

Thanks in advance!

@tesonep
Copy link
Collaborator

tesonep commented Dec 7, 2021

I have integrated the changes in libGit. Thanks a lot for the PR.

@tesonep tesonep closed this as completed Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants