New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM version is hardcoded in the bootstrap #2130

Closed
jecisc opened this Issue Dec 27, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@jecisc
Copy link
Member

jecisc commented Dec 27, 2018

Currently, the VM to download during the bootstrap is hardcoded to be the stable VM for Pharo 7.

I think it should not hardcode the 70 because for Pharo 8 we will need the one for 80.

Here is where it is hardcoded: https://github.com/pharo-project/pharo/blob/Pharo7.0/bootstrap/scripts/2-download.sh#L33

@jecisc

This comment has been minimized.

Copy link
Member

jecisc commented Dec 27, 2018

In the same idea, the pharo.version file generated is also hardcoded:

https://github.com/pharo-project/pharo/blob/Pharo7.0/bootstrap/scripts/4-build.sh#L225

@estebanlm estebanlm added this to the 8.0.0 milestone Jan 10, 2019

@estebanlm

This comment has been minimized.

Copy link
Member

estebanlm commented Jan 10, 2019

not hardcoded anymore, but for now forced to answer "70" anyway (because there is no "80" yet)

@estebanlm estebanlm closed this Jan 10, 2019

@estebanlm estebanlm assigned estebanlm and unassigned estebanlm Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment