Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify and cleanup #compactAll OrderedCollection #2824

Closed
MarcusDenker opened this Issue Mar 14, 2019 · 1 comment

Comments

Projects
3 participants
@MarcusDenker
Copy link
Member

MarcusDenker commented Mar 14, 2019

  • OrderedCollection had #compactInstances: add #compactAll and call it in cleanUp: just like HashedCollection
  • remove Behaviour >>compress (not called, can be called manually if needed (methodDict rehash_
  • #cleanUpForRelease
    -- remove explicit call to #compactInstances, as this is now done with the #cleanup
    -- add a final #rehash of all HashedCollections at the end

@MarcusDenker MarcusDenker added this to Backlog in Cleanup via automation Mar 15, 2019

@MarcusDenker

This comment has been minimized.

Copy link
Member Author

MarcusDenker commented Mar 15, 2019

Fix: #2825

(no idea why not added automatically)

@MarcusDenker MarcusDenker added the review label Mar 15, 2019

@MarcusDenker MarcusDenker moved this from Backlog to Review Needed in Cleanup Mar 15, 2019

@MarcusDenker MarcusDenker moved this from Review Needed to Working On in Cleanup Mar 15, 2019

@MarcusDenker MarcusDenker moved this from Working On to Review Needed in Cleanup Mar 15, 2019

@Ducasse Ducasse closed this Mar 15, 2019

Cleanup automation moved this from Review Needed to Closed Mar 15, 2019

@cdlm cdlm removed the review label Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.