Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we should rename NEC and NOC Controller into CompletionEngine #3113

Open
Ducasse opened this Issue Mar 29, 2019 · 3 comments

Comments

1 participant
@Ducasse
Copy link
Member

Ducasse commented Mar 29, 2019

Name name names....

@Ducasse

This comment has been minimized.

Copy link
Member Author

Ducasse commented Mar 30, 2019

Tx marcus. I'm doing it now because I'm fedup to read these names.

@Ducasse

This comment has been minimized.

Copy link
Member Author

Ducasse commented Mar 30, 2019

I'm trying to come up with a better name because they are a kind of controller since they are talking to morph. Now may be Completer would be better. Then we will have to move the Preferences into the class because this is super strange to have code like that....

newSmartCharacterInsertionStringForLeft: left right: right
((NECPreferences smartCharactersWithDoubleSpace includes: left) or: [
(NECPreferences smartCharactersWithDoubleSpace includes: right)])
ifTrue: [
^ String with: left with: Character space with: Character space with: right ].

((NECPreferences smartCharactersWithSingleSpace includes: left) or: [
(NECPreferences smartCharactersWithSingleSpace includes: right)])
ifTrue: [ 
	^ String with: left with: Character space  with: right ].

^ String with: left with: right
@Ducasse

This comment has been minimized.

Copy link
Member Author

Ducasse commented Mar 30, 2019

Argh lost my changes.... will redo it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.