Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Losing class side instance variables on class redefinition #3114

Open
Ducasse opened this Issue Mar 30, 2019 · 2 comments

Comments

4 participants
@Ducasse
Copy link
Member

Ducasse commented Mar 30, 2019

Hi

I was introducing a new superclass to NECController and I lost its class instance variables.
Here is what I did.

  • Define a class that inherit from Object
    Object subclass: #NullCompletionEngine
  • changed
    Object subclass: #NECController
    instanceVariableNames: 'model menuMorph editor context inverseMapping completionDelay'
    classVariableNames: 'ContextClass'
    package: 'NECompletion-View'

to

NullCompletionEngine subclass: #NECController
instanceVariableNames: 'model menuMorph editor context inverseMapping completionDelay'
classVariableNames: 'ContextClass'
package: 'NECompletion-View'

The NECController lost its class instance variable uniqueInstance.

@MarcusDenker

This comment has been minimized.

Copy link
Member

MarcusDenker commented Mar 30, 2019

bug was likely introduced by #2777

@MarcusDenker

This comment has been minimized.

Copy link
Member

MarcusDenker commented Mar 30, 2019

another thing that might be related: #fillFor: does not set the class instance variables (I saw that when doing #2901 )

@MarcusDenker MarcusDenker added this to To do in First Class Variables (Slots) via automation Mar 30, 2019

@guillep guillep added the Bug label Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.