Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment why name cache in SystemDictionary is sorted #4306

Closed
MarcusDenker opened this issue Aug 13, 2019 · 3 comments

Comments

@MarcusDenker
Copy link
Member

commented Aug 13, 2019

with removing the sorting of the cached class names (see #4274)

#hasBindingThatBeginsWith: does not work anymore, as it was using a search strategy based on the fact that it was ordered.

This was indeed faster, but I wonder of we need all that complexity?

@Ducasse

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

imagine the images of certain companies with 30000 classes

@MarcusDenker

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

indeed... I will revert #4274 and add a good comment explaining why we sort the cached class names.

@MarcusDenker MarcusDenker changed the title SystemDictionary>>hasBindingThatBeginsWith: broken Add comment why name cache in SystemDictionary is sorted Aug 17, 2019

@MarcusDenker

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2019

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.