Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks are always failing #4501

Open
jecisc opened this issue Sep 5, 2019 · 0 comments

Comments

@jecisc
Copy link
Member

commented Sep 5, 2019

Benchmarks were added as validation of the PRs but currently, it's just noise because they are failing too often.

We should either improve them or disable them because a check failing too many time just cause noise because people will not check if it's a false positive or not anymore.

@jecisc jecisc changed the title Benchmark are always failing Benchmarks are always failing Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.