Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate MiniBeacon #4537

Closed
Ducasse opened this issue Sep 9, 2019 · 7 comments · Fixed by #4588

Comments

@Ducasse
Copy link
Member

commented Sep 9, 2019

I cleaned and created a mini beacon version out of Beacon.
We should integrate it.

@Ducasse

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

The code of pharo/Beacon contains the latest version. Should learn how to add beacon-core + tests to Pharo

@Ducasse Ducasse changed the title Integrate MiniBeacon. Integrate MiniBeacon Sep 10, 2019

@jecisc

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

If we integrate a logger to Pharo we should at least have a File logger IMO. Why users want a logger, it's the main one they'll use.

@Ducasse

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

well if you look at the current transcript usage in the image, they do not need a file. So if people want more then they will load it. So far I never needed a file logger and my objective is at least to offer an alternative to transcript show.

@jecisc

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

If it's just to log in a transcript, what will beacon bring more? I don't see the value to add a lot of announcements if there is no new feature.

@Ducasse

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

The same as systemLogger: having real objects instead of strings and this is a game changer.
Logging is not about strings but about objects!!!!

@akgrant43

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2019

Hi Cyril,

If it's just to log in a transcript, what will beacon bring more? I don't see the value to add a lot of announcements if there is no new feature.

Beacon brings much more than logging to the transcript.

Mostly I use in-memory loggers, e.g. CircularMemoryLogger, which means I typically log something like:

signal := StringSignal new message: 'got to here'.
signal properties at: #suspectObject put: anObject.
signal emit.

Now I can inspect the log, see where this happened in relation to other objects and inspect anObject.

I really suggest you read: http://www.humane-assessment.com/blog/debugging-duplicated-behavior-with-gtinspector/ (I know this is biased because I'm working with Doru now, but I started using this long before I joined).

I've used a file logger a couple of times in the last few years: once when the problem only occurred in headless mode, and once when the problem caused the image to become 100% cpu bound and the UI unresponsive. So the file logger definitely has a place, but it's fairly infrequent.

@akgrant43

This comment has been minimized.

Copy link
Collaborator

commented Sep 12, 2019

Hi Stef,

I've merged your changes back in to https://github.com/feenkcom/pharo-beacon if you'd like to merge directly from there.

I have some more enhancements planned, e.g. when inspecting a memory log it would be nice to be able to display relative times instead of absolute times so that performance issues are easier to spot.

Thanks for your refactoring!
Alistair

GitHub
Beacon is a small event and logging framework for pharo - feenkcom/pharo-beacon
Ducasse added a commit to Ducasse/pharo that referenced this issue Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.