Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executable comments should support a kind of skipping of the execution. #5225

Open
Ducasse opened this issue Nov 26, 2019 · 1 comment
Open

Executable comments should support a kind of skipping of the execution. #5225

Ducasse opened this issue Nov 26, 2019 · 1 comment
Assignees

Comments

@Ducasse
Copy link
Member

@Ducasse Ducasse commented Nov 26, 2019

May be we should have a simple marker to cancel the execution. This way we can avoid to have errors

"Return a collection of pharo comment nodes: expressions following the pattern expr1 >>> expr2. no-test"

so that

parseDocComments: aRBCommentNode
| ranges |
ranges := self docCommentRangesIn: aRBCommentNode contents.
^ ranges
collect: [ :range |
| expression result exps |
exps := '>>>' split: (aRBCommentNode contents copyFrom: range first to: range last).
expression := PharoDocCommentExpression new
expressionInterval: (range first to: range first + exps first size - 1);
source: aRBCommentNode contents.
result := PharoDocCommentExpression new
expressionInterval: (1 + range last - exps last size to: range last);
source: aRBCommentNode contents.
self expression: expression result: result inComment: aRBCommentNode ]

@hogoww

This comment has been minimized.

Copy link
Contributor

@hogoww hogoww commented Nov 29, 2019

Is this still a problem, or did your PR correct this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.