Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
How people can contribute to Pharo if some of the tests on the base image are not passing? #5227
I do not know how people can contribute to a system with tests that are continuously red?
On the last week, more than half of the build of Pharo 8.0 were failing. It should be unlikely to happen if the imposed rules of the PR are followed (at least one review, green tests, and benchmarks): almost none of the PR have been merged without a full green check.
Is it planned to enforce the rules on the PR or should we continue as it is now?
I can concede that some changes are critical and could be passed without all the checks but they should be marginals.
The problem is that the tests are not red because of that PR. They are red because of other problems.
What we do is that we check the failing tests and if the fail is not related, we merge.
Yes, this is not good. But the alternative is to not merge anything.
Thanks Marcus! So first we may need to solve those deeper problems. Could you link those issues so we can fix them in priority?
I think that the stability of the testing environment is very important.
For the benchmark, it could be still triggered and reported but not flagged as an issue for the test?
I already added a board for the CI: https://github.com/orgs/pharo-project/projects/11
We can use that to have an overview.