Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upcould introduce isSingleQuote in Character #5278
Comments
This comment has been minimized.
This comment has been minimized.
What if it is packaged in a separate package? |
This comment has been minimized.
This comment has been minimized.
why not now are we really about on method while did you look at the 15 methods introduced by unicode that I'm pretty sure we will never use? did you check the API? Writing character = $' and = $" in all kind of places is not really nice. Of course I packaged it in my package and can not care at all. #(#< #= #> #alt #asCharacter #asHTMLString #asInteger #asKeyCombination #asLowercase #asShortcut #asString #asSymbol #asText #asUnicode #asUnicodeChar #asUppercase #asciiValue #basicIdentityHash #basicPharoToIso #basicSqueakToIso #canBeGlobalVarInitial #canBeNonGlobalVarInitial #charCode #characterSet #codePoint #command #control #copy #ctrl #deepCopy #digitValue #fuelAccept: #gtInspectorCharacterIn: #hash #hex #hexDigitValue #isAlphaNumeric #isArrow #isCasedLetter #isCharacter #isClosePunctuation #isCompletionCharacter #isConnectorPunctuation #isControlOther #isCurrencySymbol #isDashPunctuation #isDecimalDigit #isDigit #isEnclosingMark #isFinalQuote #isFormatOther #isInitialQuote #isLetter #isLetterModifier #isLetterNumber #isLineSeparator #isLiteral #isLowercase #isMathSymbol #isModifierSymbol #isNonspacingMark #isOctetCharacter #isOpenPunctuation #isOtherLetter #isOtherNumber #isOtherPunctuation #isOtherSymbol #isParagraphSeparator #isPrivateOther #isSafeForHTTP #isSeparator #isSpaceSeparator #isSpacingCombiningMark #isSpecial #isSurrogateOther #isTitlecaseLetter #isUppercase #isVowel #join: #largeIdentityHash #leadingChar #lowercase #macRomanToUnicode #meta #printOn: #printStringHex #sameAs: #serializeOn: #setValue: #shallowCopy #shift #shouldBePrintedAsLiteral #stonOn: #storeBinaryOn: #storeOn: #to: #tokenish #unicodeToMacRoman #uppercase #veryDeepCopyWith:) |
This comment has been minimized.
This comment has been minimized.
And you see in my parser I do not use = $' but |
This comment has been minimized.
This comment has been minimized.
Yes, it would be nice to clean them :(
Ok, so the point is how do we share that behaviour between many parsers? I'm not saying that the method you propose shouldn't be in the image. It can be in a separate package and still in the base distribution. I'm just suggesting it should not be mandatory in the bootstrap (as String is...) :). For example, we could have a Maybe I can take Character cleaning as one of my solo projects in my new isolated office |
This comment has been minimized.
This comment has been minimized.
I started to group the Unicode method in a specific protocol. Looking at any core classes you will find ways to improve it. I was reading superficially the Parser class and it had dead code and method that should be moved to subclass. I was not happy also with the parser tests. |
Because this is useful for building scanners and other lexers.