Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Calypso] Class definition mode is wrong (should not be a comment mode) #7166

Closed
Ducasse opened this issue Aug 23, 2020 · 1 comment · Fixed by #7167
Closed

[Calypso] Class definition mode is wrong (should not be a comment mode) #7166

Ducasse opened this issue Aug 23, 2020 · 1 comment · Fixed by #7167
Assignees
@Ducasse
Labels
Type: Bug

Comments

@Ducasse
Copy link
Member

Ducasse commented Aug 23, 2020

I introduced a regression with #7157
Now I do not understand why changing the

ClyClassCommentToolMorph>> editingMode
^ RubSmalltalkCommentMode new

impacts the
ClyClassDefinitionToolMorph editing mode!
@Ducasse Ducasse self-assigned this Aug 23, 2020
@Ducasse
Copy link
Member Author

Ducasse commented Aug 23, 2020

Found it
editingMode was defined in superclass instead of ClyClassCommentEditorToolMorph.
PR on the way

@Ducasse Ducasse mentioned this issue Aug 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ducasse Ducasse

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

7166-Calypso-Class-definition-mode-is-wrong-should-not-be-a-comment-mode
1 participant
@Ducasse