Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow catalog json to be served from GitHub and other #7737

Closed
astares opened this issue Nov 16, 2020 · 1 comment · Fixed by #7738
Closed

Allow catalog json to be served from GitHub and other #7737

astares opened this issue Nov 16, 2020 · 1 comment · Fixed by #7738

Comments

@astares
Copy link
Member

astares commented Nov 16, 2020

Set the catalog source URL to a JSON that is provided by a GitHub location
and Pharo will fail to load it as currently only json mimetype is supported.

We should not restrict to also allow other like text/plain.

One can try out using the given URL:

https://raw.githubusercontent.com/astares/pharo-catalog/main/build/catalog.json

@astares
Copy link
Member Author

astares commented Nov 16, 2020

To test try

CatalogSettings catalogSourceURL: 'https://raw.githubusercontent.com/astares/pharo-catalog/main/build/catalog.json'.

CatalogProvider default reset.
CatalogBrowser open

without and with the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant