Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OCUndeclaredVariableWarning>>declareTempAndPaste #12978

Merged
merged 5 commits into from Mar 15, 2023

Conversation

privat
Copy link
Contributor

@privat privat commented Mar 13, 2023

Low-hanging fruit. A small cleanup of declareTempAndPaste that reduces the hackish level a little

  • reclassify and remove hack
  • remove unused math (and a parameter)

@Ducasse
Copy link
Member

Ducasse commented Mar 13, 2023

Thanks for cleaning this prehistorical code (and it was not the original compiler but a "new one" but with left over of other hacks).

@MarcusDenker
Copy link
Member

Yes, and the whole idea (to fix the code during exception handling) is just plain bad.

@estebanlm
Copy link
Member

please do not submit more enhancements until we open P12 development.
right now, we are just accepting bugfixes.

@privat
Copy link
Contributor Author

privat commented Mar 13, 2023

@estebanlm yes, it is intended pf P12. Unfortunately, I'm not able to set the pharo12 tag myself.

@privat privat changed the base branch from Pharo11 to Pharo12 March 14, 2023 13:46
@tesonep tesonep added this to the 12.0.0 milestone Mar 15, 2023
@privat privat changed the base branch from Pharo12 to Pharo11 March 15, 2023 20:33
@privat privat changed the base branch from Pharo11 to Pharo12 March 15, 2023 20:33
@MarcusDenker MarcusDenker merged commit fdbcbb0 into pharo-project:Pharo12 Mar 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants