Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency of Collections-Abstract/Sequenceable over Random-Core #13294

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Apr 5, 2023

Until now Random-Core was depending on Collection-Abstract and Collections-Sequenceable but both those packages also depended on Random-Core.

This PR removes the dependency of those collections over Random-Core. For now their tests are still depending on it and maybe the tests should be in Random-Tests instead, but this is a concern for later.

It also adds a test to ensure that it will not be added again in the future. The cherry on top is that I extracted the time limit of dependencies tests to apply for all tests.

Until now Random-Core was depending on Collection-Abstract and Collections-Sequenceable but both those packages also depended on Random-Core.
This removes the dependency  of those two collections packages to Random-Core.
@Ducasse Ducasse merged commit d7295fb into pharo-project:Pharo12 Apr 6, 2023
1 of 2 checks passed
@jecisc jecisc deleted the cut-random-and-collections-cyclic-dependency branch April 6, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants