Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committing changes from GustavoSantos/Refactoring2 on Smalltalkhub #1695

Conversation

gustavojss
Copy link
Contributor

In this commit I introduce:

  • new package Refactoring2
  • Code Transformations to be distinguished from Refactorings
  • precondition checking is optional
  • atomic transformations to be distinguished from composite ones
  • examples of existing Refactoring, such as "Extract Method" and "Push Down Variable", as composite transformations
  • introduction of new composite transformations, such as "Deprecate Class" and "Rename and Deprecate Class"

@Ducasse
Copy link
Member

Ducasse commented Aug 20, 2018

Super cool! I will have a look!

@Ducasse
Copy link
Member

Ducasse commented Aug 22, 2018

Pavel do you know if Refactoring2 should be added to a baseline? I have to check the code.

@Ducasse
Copy link
Member

Ducasse commented Aug 31, 2018

Gustavo do you have tests?

@Ducasse
Copy link
Member

Ducasse commented Aug 31, 2018

We saw the tests.
Now why do you have a new BRClass2?

@Ducasse
Copy link
Member

Ducasse commented Aug 31, 2018

You have tests for the transformations and I would like to know how I can change the refactorings to use your transformation and check the tests.

@gustavojss
Copy link
Contributor Author

  • I created RBNamespace2 and RBClass2 because I wanted to change the original classes without breaking the existing refactorings. It's in my long-term plan to completely refactor these classes because they are too big
  • I test the preconditions in my tests; and for that purpose, I use transformations as refactorings. When you instantiate a *Transformation, you can send #asRefactoring then #transform

@Ducasse
Copy link
Member

Ducasse commented Aug 31, 2018

Thanks for the information I will have a look.

pavel-krivanek and others added 4 commits September 1, 2018 18:26
@pavel-krivanek
Copy link
Collaborator

I think that the tests should be placed in a separate package, they are now part of Refactoring2-Transformations

@estebanlm estebanlm merged commit 6402bdc into pharo-project:development Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants