22478 button presenter does not take into account its color #1820
Conversation
This decorator allows to override some parts of a UITheme.
|
@pavel-krivanek you might be interested to review this change since you did SpecDemo :-) |
| ] | ||
|
|
||
| { #category : #'reflective operations' } | ||
| UIThemeDecorator >> doesNotUnderstand: aMessage [ |
There was a problem hiding this comment.
Do we really need to override doesNotUnderstand:?
There was a problem hiding this comment.
Well, the goal is to let the UITheme decorated continue to answer to style messages that are not overridden by the decorator.
If you have another idea on how to do it without modifying the whole theme mechanism, I'd be happy to implement another solution.
| property: #buttonNormalFillStyleFor: returnsValueOf: normalColorBlock; | ||
| property: #buttonMouseOverFillStyleFor: returnsValueOf: normalColorBlock; | ||
| property: #buttonPressedFillStyleFor: returnsValueOf: clickedColorBlock; | ||
| yourself). |
There was a problem hiding this comment.
I don't quite like the usage of blocks here...
There was a problem hiding this comment.
Look at the implementation of UITheme>>#buttonNormalFillStyleFor:, I just wanted to keep a similar behaviour.
However, if it is ok to do it, UIThemeDecorator allows one to do something like:
themeDecorator property: #buttonNormalFillStyleFor: returnsValueOf: (SolidFillStyle color: Color red)
|
Actually, I'm not sure if we should support Spec colors this way at all... But since this PR is limited only to the MorphicAdapter of Button presenter, I think we can integrate it as (hopefully) temporary solution |
|
@pavel-krivanek what kind of support for colours do you expect in Spec? |
Fixed the bug.
Had to introduce UIThemeDecorator which allows one to dynamically override some parts of a theme.
This is used to override buttons colors.
Now, SpecDemo red button is working:
And with dynamic spec builder you can do funny stuff:
