Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2699 - backport pharo-vcs/tonel bug fix #2700

Merged
merged 1 commit into from Feb 25, 2019

Conversation

Projects
None yet
3 participants
@badetitou
Copy link
Contributor

badetitou commented Feb 22, 2019

Backport the bug fix #2373 (pull request #2530 )

The bug was in :

ByteSymbol(Object)>>doesNotUnderstand: #categories
TonelWriter>>obtainPackageDir:
TonelWriter>>writePackage:
TonelWriter>>writeSnapshot:
TonelWriterTest>>testWriteSnapshotWithoutOrganization
TonelWriterTest(TestCase)>>performTest

Esteban told me I should change something in the BaselineOfIDE, but I did not find the line to change because there is ne reference to pharo-vcs/tonel (sorry)

@badetitou badetitou changed the title backport pharo-vcs/tonel bug fix 2699 - backport pharo-vcs/tonel bug fix Feb 23, 2019

@estebanlm estebanlm closed this Feb 25, 2019

@estebanlm estebanlm reopened this Feb 25, 2019

@estebanlm estebanlm added the review label Feb 25, 2019

@estebanlm estebanlm merged commit 890f474 into pharo-project:Pharo7.0 Feb 25, 2019

1 check failed

continuous-integration/jenkins/pr-merge This commit has test failures
Details

@estebanlm estebanlm removed the review label Feb 25, 2019

@akgrant43

This comment has been minimized.

Copy link
Collaborator

akgrant43 commented Feb 25, 2019

Hi @estebanlm ,

Did you reopen this because it had a VM crash? And if so, was it basically the same as the Pharo 8 CI VM crashes (the smalltalk stack trace has a bunch of Context>>copyTo:, and the top call is Context(Object)>>copy)?

Thanks,
Alistair

@badetitou

This comment has been minimized.

Copy link
Contributor Author

badetitou commented Feb 26, 2019

I've seen that the pull request does not solve the bug...
I should do another one ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.