Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (P7) forked processes of TestResource from being terminated between TestCase methods being executed #3605

Conversation

@ErikOnBike
Copy link
Contributor

commented Jun 21, 2019

Fixes issue number 3582 in Pharo7.0 branche (another PR is already created for Pharo8.0 branche)

@ErikOnBike

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

CI error seems unrelated

@MarcusDenker

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

This should be merged after #3583 has been merged in Pharo8

@MarcusDenker

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

#3583 has been merged and seems to work.

@MarcusDenker MarcusDenker added this to Ideas in Sprint via automation Jun 28, 2019

@MarcusDenker MarcusDenker moved this from Ideas to Review Needed in Sprint Jun 28, 2019

@MarcusDenker

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

We use this in Pharo 8 for some days with no reported problems: save to merger

@MarcusDenker MarcusDenker merged commit 814fd1b into pharo-project:Pharo7.0 Jun 28, 2019

2 of 3 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
WIP Ready for review
Details
probot/minimum-reviews No pending reviews

Sprint automation moved this from Review Needed to DONE Jun 28, 2019

@ErikOnBike ErikOnBike deleted the ErikOnBike:3582-P7-fix-forked-processes-in-test-resource branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.