New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17754-CheckBoxModel--RadioButtonModel-ignore-disable #372

Merged
merged 2 commits into from Oct 18, 2017

Conversation

Projects
None yet
3 participants
@hernanmd
Contributor

hernanmd commented Oct 17, 2017

Set the enablement selector for both RadioButton and CheckBox.
This patch acts on both versions: CheckBoxModel, RadioButtonModel (Deperecated in Pharo70) and CheckBoxPresenter, RadioButtonPresenter.
You could evaluate the following expressions before and after the fix:

CheckBoxPresenter new
label: 'CheckBoxPresenter';
disable;
openWithSpec.

RadioButtonPresenter new
label: 'RadioButtonPresenter';
disable;
openWithSpec.

Set the enablement selector for both RadioButton and CheckBox.
This patch acts on both versions: CheckBoxModel, RadioButtonModel (Deperecated in Pharo70) and CheckBoxPresenter, RadioButtonPresenter.
You could evaluate the following expressions before and after the fix:

CheckBoxPresenter new
    label: 'CheckBoxPresenter';
    disable;
    openWithSpec.

RadioButtonPresenter new
    label: 'RadioButtonPresenter';
    disable;
    openWithSpec.
@pavel-krivanek

We should integrate into Pharo 7 without -Model extensions and backport it into Pharo 6. Please, remove the two methods from this PR

@MarcusDenker MarcusDenker merged commit 1f1913a into pharo-project:development Oct 18, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment