Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of fix for diamond problem in traits with slots. #3736

Conversation

@tesonep
Copy link
Collaborator

commented Jul 2, 2019

This fix handles the validation of slots that came from different traits but they are defined in a single trait.

As they are defined once they should not be a conflict.

This fix handles the validation of slots that came from different tra…
…its but they are defined in a single trait.

As they are defined once they should not be a conflict.
@MarcusDenker

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

CI failures are not related

@MarcusDenker MarcusDenker merged commit 591a635 into pharo-project:Pharo7.0 Jul 15, 2019

2 of 3 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
WIP Ready for review
Details
probot/minimum-reviews No pending reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.