Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4026 migration of critic browser spec to spec 2 #4148

Open
wants to merge 41 commits into
base: Pharo8.0
from

Conversation

@CafeKrem
Copy link
Contributor

CafeKrem commented Jul 29, 2019

No description provided.

CafeKrem and others added 28 commits Jul 22, 2019
…c-to-Spec-2-

4026-migration-of-CriticBrowser-Spec-to-Spec-2-
…c-to-Spec-2-

4026-migration-of-CriticBrowser-Spec-to-Spec-2-
…c-to-Spec-2-

4026-migration-of-CriticBrowser-Spec-to-Spec-2-
@request-info

This comment has been minimized.

Copy link

request-info bot commented Jul 29, 2019

This issue has either a default title or empty body. We would appreciate it if you could provide more information. Note: I am not a very intelligent bot, I can only react to new comments. Please add a comment for me if you update the body or title.

@Ducasse Ducasse closed this Jul 30, 2019
@Ducasse Ducasse reopened this Jul 30, 2019
@Ducasse

This comment has been minimized.

Copy link
Member

Ducasse commented Jul 30, 2019

Relaunching the build

@CafeKrem

This comment has been minimized.

Copy link
Contributor Author

CafeKrem commented Jul 30, 2019

same CI break with the same error

@Ducasse

This comment has been minimized.

Copy link
Member

Ducasse commented Jul 30, 2019

Ouch I will try to integrate another PR to see.

@guillep

This comment has been minimized.

Copy link
Member

guillep commented Jul 30, 2019

Now there are just broken tests, that seem unrelated.

@CafeKrem are you writing tests about your new UIs?

@CafeKrem

This comment has been minimized.

Copy link
Contributor Author

CafeKrem commented Jul 31, 2019

yes

Copy link
Member

guillep left a comment

Some comments while I was having lunch :)

src/BaselineOfIDE/BaselineOfIDE.class.st Show resolved Hide resolved
src/BaselineOfIDE/BaselineOfIDE.class.st Outdated Show resolved Hide resolved
src/Tool-CriticBrowser/CBReapplyRuleCommand.class.st Outdated Show resolved Hide resolved
src/Tool-CriticBrowser/CBUnBanRuleCommand.class.st Outdated Show resolved Hide resolved
CafeKrem added 7 commits Jul 31, 2019
add  delegate some feature to rule class
TemporaryBranch
Copy link
Member

estebanlm left a comment

please replace the "ad hoc" action bars with the correct presenter.

@stale

This comment has been minimized.

Copy link

stale bot commented Aug 25, 2019

It is hard to review old PRs so this PR has been marked as stale since there has been no activity the last 20 days. It will be closed in 10 days if no further activity occurs. A simple comment will reactivate the PR, but please also consider updating the PR to the latest SNAPSHOT build to make it easier for reviewers.

@stale stale bot added the stale label Aug 25, 2019
@CafeKrem

This comment has been minimized.

Copy link
Contributor Author

CafeKrem commented Aug 28, 2019

please, can someone integrate it into Pharo?

@pavel-krivanek

This comment has been minimized.

Copy link
Collaborator

pavel-krivanek commented Sep 13, 2019

restarting CI check...

@VincentBlondeau

This comment has been minimized.

Copy link
Contributor

VincentBlondeau commented Sep 18, 2019

Conflict to solve

@stale

This comment has been minimized.

Copy link

stale bot commented Oct 8, 2019

It is hard to review old PRs so this PR has been marked as stale since there has been no activity the last 20 days. It will be closed in 10 days if no further activity occurs. A simple comment will reactivate the PR, but please also consider updating the PR to the latest SNAPSHOT build to make it easier for reviewers.

@stale stale bot added the stale label Oct 8, 2019
@MarcusDenker MarcusDenker removed the stale label Oct 10, 2019
@MarcusDenker MarcusDenker added this to To do in Spec Nov 8, 2019
@MarcusDenker MarcusDenker moved this from To do to In progress in Spec Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Spec
  
In progress
8 participants
You can’t perform that action at this time.