Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new version of add testcase for setting/getting a pointer to a long #4579

Open
wants to merge 4 commits into
base: Pharo8.0
from

Conversation

@estebanlm
Copy link
Member

estebanlm commented Sep 13, 2019

trying to fix @zecke conflicts at #3181

zecke and others added 4 commits Apr 14, 2019
…ffi-ulong-ptr

# Conflicts:
#	src/UnifiedFFI-Tests/FFIExternalStructureTest.class.st
@Ducasse

This comment has been minimized.

Copy link
Member

Ducasse commented Sep 13, 2019

Esteban you have testBuildingFnSpec – MacOSX32.UnifiedFFI.Tests.Tests.FFICalloutTest

type := generator fnSpec returnType.
self assert: type class equals: FFILong.
self assert: type pointerArity equals: 1.

self assert: (generator fnSpec arguments size) equals: 14.
s := generator fnSpec arguments readStream.

s := generator fnSpec arguments readStream.

This comment has been minimized.

Copy link
@zecke

zecke Sep 14, 2019

Contributor

looks like a out of place change?

@stale

This comment has been minimized.

Copy link

stale bot commented Oct 4, 2019

It is hard to review old PRs so this PR has been marked as stale since there has been no activity the last 20 days. It will be closed in 10 days if no further activity occurs. A simple comment will reactivate the PR, but please also consider updating the PR to the latest SNAPSHOT build to make it easier for reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.