Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update-Spec2-and-Commander-2 #4589

Merged
merged 3 commits into from Sep 13, 2019

Conversation

@jecisc
Copy link
Member

commented Sep 13, 2019

Update Spec 2 and Commander 2

@jecisc jecisc changed the title Update-Spec2 Update-Spec2-and-Commander-2 Sep 13, 2019
@jecisc

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

Spec 2 integration of the 13 of September 2019

Features

  • Add padding management of SpBoxLayout for Morphic
  • Add demo on Box Layout (978220b)
  • Add package comments (20ffe7a)
  • Add contextMenu to Athens presenters (78aefa5)
  • Allow to add an image in the layout without declaring an image presenter (748bc59)
  • Add InputPort to SpPresenterWithModel (5f7d07c)
  • Improve demos (d2e1bf1)
  • Add possiblity to pass action to link presenter (3903717)
  • Add component list presenter (cb26690)
  • Add possibility to defer UI via Spec (da86831)
  • Introduce new API: initializePresenters and connectPresenters instead of initializeWidgets and initializePresenter (6c7ebc1)
  • Use toolbar and not toolBar (f2f807f)
  • Create builder for SpActionBarPresenter (c5f1e59)
  • TextPresenter Add a placeHolder (7b7d4b5)
  • Add the method clearContent in the class SpAbstractTextPresenter (16a842d)
  • feature/improvementsForIceberg (246c1a7)

Commander 2 integration

  • Change dependency to Commander2 so it uses v110 (5ca15b3)
  • Update commander2 version (4ac485a)
  • Change dependency to Commander2 for v120 (15945ac)
  • Migrate Spec to use Commander2 v200 (c4c5350)
  • Implement method to convert spec command as ButtonPresenter (dab0312)
  • Allows one to change the default context set on commands when their context is nil (152af5e)
  • Commander2 should provide easier way to use command group on list tree etc (d80a965)
  • Commander2 layer should set the presenter as context of commands when not done (d0f2889)

Bugfixes

  • Replace Smalltalk references (c1cc561)
  • Fix grid layout tests (85719bc)
  • SpAbstractPresenter should be abstract (de681a0)
  • Migrate more layouts to executable layouts (cee71ae)
  • Use theme instead of hardcoded color in Modal adapter (be583d8)
  • TextPresenter placeholder does not work in Pharo 7 (6bbdc7b)
  • Instance of TreeTablePresenter did not understand activatesOnDoubleClick (9cda46c)
  • Fixing SpCodePresenter in pharo8 (fc5b7e8)
  • Some table columns are editable (c630a0e)
  • Fixing Baseline (3f3ac6d)

Cleanings

  • Migrate initializeWidgets and initializePresenter to new API (dd74217)
  • Clean package structure (a0706ba)
  • Remove dependency between Spec2 Commands and Commander (56ae6d4)
  • Commander2 v2 migration (0d029c0)
  • Remove all commented pragmas (ed6e844)
  • cleanup (05839d7)
  • Deprecate asSpAdapter (cb5f47c)
  • Move spec related methods on class side of CmCommand and CmCommandGroup to spec integration package (f95eca0)
  • Remove ComposablePresenter references (ef8c984)
  • Unnecessary initialize method in SpMorphPresenter (4b6828b)
  • SpExecutableLayoutresolvePresentermodelbindings should be SpExecutableLayoutresolvePresenterpresenterbindings (caa37db)
  • Fix calls to canBeRun and replace them with canBeExecuted (822db0c)
  • PolyWidget SpChooseMethod improvement (fe964f9)
  • Comment of SpPresenter mentions ComposablePresenter (d46e348)
  • Rename SpTestingComposerWithModel into SpTestingPresenterWithModel (092e6c4)

Infrastructure

Commander 2 integration of the 13 of September 2019

Features

  • Add #register:after: and #register:before:. (ad5041c)
  • Implemented part of the missing API and implemented corresponding tests. (5c91fac)

Bug fixes

  • Added missing deprecation methods to make transition from v1 to v2 smoother. (3fef319)
  • Changed string returned by #defaultDescription to be 'Not described command.' (71ad574)

Cleanings

  • Preparing for major release, removing deprecated methods we do not want in next major version: - #canBeRun - #canBeRunBlock - #canBeRunBlock: - #defaultCommandName - #runWith: (3dbd6b1)
  • Updated baseline to be more flexible. - Do not provide migrator in default group. - Provide core,test and migrator groups. (7a7491b)
  • Enhanced comment. (8379fb3)
  • Did migration with the following renamings (order is important): #name -> #dynamicName. #description -> #dynamicDescription. #basicName -> #name. #basicDescription -> #description. (1a8f4e8)
  • wrap environment into RBNamespace. (723cddd)
  • Put #runWith: in deprecations package. (cc9025d)
  • Removed #runWith: (c78dd09)
  • Renamed #defaultCommandName as #defaultName. Used deprecation. (c1bad44)
  • Renamed #canBeRunBlock as #canBeExecutedBlock via a deprecation. (5a87a11)
  • Moved spec related methods in class-side of CmCommandGroup to spec package. (4ae2f84)
  • Moved spec-specific methods on class side of CmCommand to Spec integration package. (11d7997)
  • Renamed #canBeRun as #canBeExecuted to be more consistent. Created a deprecation to ease migration of users. (152e6a7)
  • Reclassified all #canBeRun methods in 'testing' protocol. (813cda2)
  • Reclassified #execute methods in 'executing' protocol. Brings consistence and solves issue #9 (19c1ee0)
  • Renaming of CmCommandGroupTest to CmCommandsGroupTest. (5f20942)
  • Renamed test class to match class under test. (8ab2c3b)
@Ducasse

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

osx-32 / Tests-osx-32 / testNoUnusedTemporaryVariablesLeft – MacOSX32.ReleaseTests.CleanCode.NoUnusedTemporaryVariablesLeftTest
<1s
osx-32 / Tests-osx-32 / testUndeclared – MacOSX32.ReleaseTests.Release.ReleaseTest
<1s
osx-32 / Tests-osx-32 / testAndMakeSureSuperTearDownIsCalledAsLastMessageInTearDownMethodsOfTestCases – MacOSX32.ReleaseTests.Tests.ProperlyImplementedSUnitClassesTest
<1s
osx-32 / Tests-osx-32 / testExternalBasicToolsDependencies – MacOSX32.System.DependenciesTests.SystemDependenciesTest
<1s
osx-32 / Tests-osx-32 / testExternalIDEDependencies – MacOSX32.System.DependenciesTests.SystemDependenciesTest
<1s
osx-32 / Tests-osx-32 / testExternalSpec2Dependencies – MacOSX32.System.DependenciesTests.SystemDependenciesTest
<1s
osx-32 / Tests-osx-32 / testExternalUIDependencies – MacOSX32.System.DependenciesTests.SystemDependenciesTest

@jecisc

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

Looking at it now.

@jecisc

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

Tests are now passing.

@Ducasse Ducasse merged commit f757013 into pharo-project:Pharo8.0 Sep 13, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
probot/minimum-reviews Pending review approvals
WIP Ready for review
Details
@Ducasse

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

Massive

@guillep

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

Hi Cyril, can you put in the issue description / commit comment what tag corresponds to this version? so we can track it back :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.