Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4620-Simplify-FloatArray-handling #4621

Open
wants to merge 1 commit into
base: Pharo8.0
from

Conversation

@astares
Copy link
Member

astares commented Sep 16, 2019

Simplify FloatArray handling

Fix #4620

Fix #4620
@@ -228,7 +228,7 @@ SequenceableCollection >> asFloatArray [

| floatArray |
floatArray := FloatArray new: self size.
1 to: self size do:[:i| floatArray at: i put: (self at: i) asFloat ].
self withIndexDo: [:el :i| floatArray at: i put: el asFloat ].

This comment has been minimized.

Copy link
@jecisc

jecisc Sep 16, 2019

Member

I am not sure about this change because using #to:do: is faster. So it might be used for performance reasons.

@stale

This comment has been minimized.

Copy link

stale bot commented Oct 6, 2019

It is hard to review old PRs so this PR has been marked as stale since there has been no activity the last 20 days. It will be closed in 10 days if no further activity occurs. A simple comment will reactivate the PR, but please also consider updating the PR to the latest SNAPSHOT build to make it easier for reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.