Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
As you see from the discussion on the ML this is not yet decided which path Pharo will go with slots in the class definition. First Marcus will work on the slot compositions and then we will see which way we go with the parser.
Currently the CDCParser is unfinished but already integrated. It leaves the context menu broken when a slot object definition is done using a class message - which makes it unusable to work with Calypso.
For now this PR just avoids the debug context menu - so yes it is a workaround for the time being.
Hi @astares .
I disagree with you. Whatever syntax we will choose the class parser should not fail on such expressions.
Currently the only user of class parser is "Calypso commands machinery". But idea is to use it for class creation. CMD+s on class creation tab in the browser will parse definition written by user and it should not fail on incorrect syntax.
So I think we need the test covering slot definition part starting with global name
It is hard to review old PRs so this PR has been marked as stale since there has been no activity the last 20 days. It will be closed in 10 days if no further activity occurs. A simple comment will reactivate the PR, but please also consider updating the PR to the latest SNAPSHOT build to make it easier for reviewers.