Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use #lookupVar: instead of #lookupVarForDeclaration: #4851

Merged
merged 2 commits into from Oct 8, 2019

Conversation

@MarcusDenker
Copy link
Member

MarcusDenker commented Oct 7, 2019

No idea why we have #lookupVar: and #lookupVarForDeclaration. Opal tests are green without it

MarcusDenker added 2 commits Oct 7, 2019
…sts are green without it
@MarcusDenker MarcusDenker merged commit 598e2a9 into pharo-project:Pharo8.0 Oct 8, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/jenkins/pr-merge This commit has test failures
Details
probot/minimum-reviews Pending review approvals
WIP Ready for review
Details
@tesonep

This comment has been minimized.

Copy link
Collaborator

tesonep commented Oct 8, 2019

@MarcusDenker this fix is not allowing the playground to evaluate code using a block with temporaries or parameters

@MarcusDenker

This comment has been minimized.

Copy link
Member Author

MarcusDenker commented Oct 8, 2019

Ah... I will revert and check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.