Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opal: compiler shoud not copy AST for pluging #4858

Merged

Conversation

@MarcusDenker
Copy link
Member

MarcusDenker commented Oct 8, 2019

the compiler does not need to copy the AST before calling plugins as they can do that if needed. Speeds up compilation by 3-5%

…they can do that if needed. Speeds up compilation by 3-5%
@MarcusDenker

This comment has been minimized.

Copy link
Member Author

MarcusDenker commented Oct 8, 2019

recompile of whole image is 45 seconds before, 42 seconds after

@MarcusDenker MarcusDenker merged commit 91a7e02 into pharo-project:Pharo8.0 Oct 8, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
probot/minimum-reviews Pending review approvals
WIP Ready for review
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.