Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a browse menu item #4864

Conversation

@leonardoce
Copy link
Contributor

leonardoce commented Oct 8, 2019

The new menu item will evaluate the current selection and then open its
class. It can be used in the system browser and also in the Playground.

Fixes: #4839

The new menu item will evaluate the current selection and then open its
class. It can be used in the system browser and also in the Playground.

Fixes: #4839
@leonardoce

This comment has been minimized.

Copy link
Contributor Author

leonardoce commented Oct 8, 2019

I hope to have understood correctly the request by @Ducasse.
In this moment, I haven't bound any shortcut to the new action.

This is the look of the contextual menu of the playground after the patch:

Screenshot from 2019-10-08 22-18-25

And this is what can be seen from the browser:

Screenshot from 2019-10-08 22-18-50

@Ducasse

This comment has been minimized.

Copy link
Member

Ducasse commented Oct 8, 2019

This is cool.
Thanks I will review it tomorrow.

@estebanlm

This comment has been minimized.

Copy link
Member

estebanlm commented Oct 9, 2019

there is already a "browse it", under "code search" submenu (along with "senders" and "implementors".
Why do we need this new one?

@Ducasse

This comment has been minimized.

Copy link
Member

Ducasse commented Oct 27, 2019

I extended super simply browse to handle
Point browse
10@10 browse
No need for a new entry and now we can select an expression or self!!!!

@Ducasse Ducasse closed this Oct 27, 2019
Ducasse added a commit to Ducasse/pharo that referenced this pull request Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.