Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: Clean dead code #4870

Merged
merged 2 commits into from Oct 10, 2019

Conversation

@MarcusDenker
Copy link
Member

MarcusDenker commented Oct 9, 2019

  • IRMethod>>#removeReturn is dead code
  • IRPushClosureCopy ivar "lastBlockSequence" is set but never used (and not documented)
  • #lookUpSelector:, possibleSelectorFor: and #lookUpGlobalVar: on semantic scope are not needed
  • formatting of #hasTemporaryVariableNamed: (remove () )
- IRPushClosureCopy ivar "lastBlockSequence" is set but never used (and not documented)
- #lookUpSelector:,  possibleSelectorFor: and #lookUpGlobalVar: on semantic scope are not needed
- formatting of #hasTemporaryVariableNamed: (remove () )
…t is handed over, this avoids lots of unneded allocations
@MarcusDenker MarcusDenker merged commit 0ddf0c3 into pharo-project:Pharo8.0 Oct 10, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
probot/minimum-reviews Pending review approvals
WIP Ready for review
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.